[MODLISTS-57] Soft deletion within lists #57
Conversation
| import org.folio.list.domain.dto.ListUpdateRequestDTO; | ||
| import org.folio.list.exception.AbstractListException; | ||
| import org.folio.list.rest.UsersClient.User; | ||
| import org.folio.list.util.TaskTimer; | ||
|
|
||
| @Data | ||
| @With |
There was a problem hiding this comment.
This generates methods like withIsDeleted, withName, etc., which clones and edits one field in a fluent manner.
There was a problem hiding this comment.
Totally out of scope and I'm not asking for any changes, but I just need to complain...
ngl, I really hate everything about this class, but I don't care enough to go out of my way to change it... It's like a perfect storm of things that annoy me: odd class name + lombok + ORM + mutability + leaky abstraction (it has a dependency on something in UserClient) + business logic in a data class (with no comments, no less)
There was a problem hiding this comment.
Agreed. We could do a quick clean up noise-wise at least by removing the @Column's (it'll derive from fields), and changing some to primitives (removes @NotNull's) — super minor change, but would save a smidge of sanity
| import java.util.UUID; | ||
|
|
||
| @Repository | ||
| public interface ListRepository extends CrudRepository<ListEntity, UUID>, PagingAndSortingRepository<ListEntity, UUID> { | ||
|
|
||
| Optional<ListEntity> findByIdAndIsDeletedFalse(UUID id); |
There was a problem hiding this comment.
Spring derives the query for us
ncovercash
changed the title
src/test/java/org/folio/list/controller/ListControllerGetListsTest.java
Outdated
Show resolved
Hide resolved
|
Jira MODLISTS-57
Purpose
Lists should be able to be soft deleted and later accessible via the main
/listsendpoint with special query parameterincludeDeleted.Deleted lists should no longer be accessible via
/lists/{id}/*.Out of scope